feat: switched from scroll view to custom scroller #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkonecny2
force-pushed
the
feat/custom-scroller
branch
from
82e3f34 to
937bfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like there are some issues with Android implementation of scroll view causing frame drops and #3. This PR replaces ScrollView with View being moved by style translations which should give us much more control over the scroll behavior.
By introducing an Adapter between the scroll component and AutoCarousel it should be easy to switch between ScrollView and the custom implementation for testing and possibly add another scroll view implementation.
Related Tickets/Issues
#3